[VC-52458] Support both number and string for tsgID#798
Merged
Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
changed the title
Member
|
Works as expected, nice, thanks for fixing this. For whaat it's worth, the string-based methods still work as expected: $ helm template ./deploy/charts/discovery-agent \
--set config.tsgID=\\"111\\" \
--set config.clusterName=aaa | grep 111
- "111"$ helm template ./deploy/charts/discovery-agent \
--set-string config.tsgID=111 \
--set config.clusterName=aaa | grep 111
- "111" |
maelvls
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback, this change updates tsgID to accept both numbers and strings.
Previously, the Helm chart’s values.schema.json enforced tsgID as a string. However, this constraint introduced unnecessary friction for users during initial setup.
To improve the user experience, we now allow both numeric and string inputs. As a side effect, this adds some complexity to the chart implementation, requiring a workaround for a Helm issue related to scientific notation handling.
context: in #793 we enforced tsgID to be a string